Subject: Re: [PATCH] netxen: sparse warning and ioctl bug fixes

From: Jeff Garzik <[email-masked]>
Date: Thu, 07 Dec 2006 05:00:11 -0500

Stephen Hemminger wrote:
> Fix sparse warnings and get rid of casts that hide misuse
> of __user pointers.  There were two real bugs here:
>   * ioctl was copying uninitialized stack om NETXEN_NIC_NAME
>   * ioctl was dereferencing a user pointer
>     in nettxen_nic_cmd_clear_stats.
> 
> IMHO the ioctl usage in this driver is going to be more maintenance
> burden than useful. and should be removed.
> 
> Signed-off-by: Stephen Hemminger <[email-masked]>

ACK but netxen is in heavy flux right now, with upstream workqueue 
changes, changes from Amit, etc.  so, it didn't apply.

Ever considered submitting via git?  :)

	Jeff