Subject: Re: [PATCH] myri10ge: pci msi and express state save/restore

From: Brice Goglin <[email-masked]>
Date: Fri, 08 Dec 2006 18:28:07 +0100

It looks ok to me, except that you should also remove devctl and
msi_flags from myri10ge_priv since these fields were only used in the
functions that are dropped by this patch.

However, I won't be able to test the patch on real hardware within the
next days...

Thanks a lot!
Brice

Stephen Hemminger wrote:
> The PCI MSI and express state are already saved and restored by the
> current versions of pci_save_state/pci_restore_state.
> Therefore it should no longer be necessary for the driver to do it.
> This patch has not been tested on the hardware.
>
> On suspend, handle pci_set_power_state errors, and on resume
> handle failures in pci_resume_state().
>
> Signed-off-by: Stephen Hemminger <[email-masked]>
>
> ---
>  drivers/net/myri10ge/myri10ge.c |   48 +++++++++-------------------------------
>  1 file changed, 11 insertions(+), 37 deletions(-)
>