Subject: Re: [PATCH 13/22] e1000: disable TSO when debugging slab

From: Jeff Garzik <[email-masked]>
Date: Mon, 11 Dec 2006 09:47:05 -0500

Kok, Auke wrote:
> CONFIG_DEBUG_SLAB kills TSO on the 82544, so we're better off turing TSO
> off in this rare case, assuming performance is not an issue for people
> running slab debugging.
> 
> Signed-off-by: Jesse Brandeburg <[email-masked]>
> Signed-off-by: Auke Kok <[email-masked]>
> ---
> 
>  drivers/net/e1000/e1000_main.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
> index 9ddcadd..12f9f61 100644
> --- a/drivers/net/e1000/e1000_main.c
> +++ b/drivers/net/e1000/e1000_main.c
> @@ -998,6 +998,12 @@ e1000_probe(struct pci_dev *pdev,
>  	   (adapter->hw.mac_type != e1000_82547))
>  		netdev->features |= NETIF_F_TSO;
>  
> +#ifdef CONFIG_DEBUG_SLAB
> +	/* 82544's work arounds do not play nicely with DEBUG SLAB */
> +	if (adapter->hw.mac_type == e1000_82544)
> +		netdev->features &= ~NETIF_F_TSO;
> +#endif

ACK, provided that you greatly enhance the comment to explain -why-, not 
just the desired results.