Subject: Re: [PATCH 1/1] bonding: eliminate RTNL assertion spew

From: Jeff Garzik <[email-masked]>
Date: Tue, 09 Jan 2007 18:13:55 -0500

Andy Gospodarek wrote:
> -void bond_alb_handle_active_change(struct bonding *bond, struct slave *new_slave)
> +void bond_alb_handle_active_change(struct bonding *bond, struct slave *new_slave, int rtnl_locked)
>  {
>  	struct slave *swap_slave;
>  	int i;

Although this is not a direct NAK (haven't read the full patch yet), 
conditional locking behavior like this is /very/ fragile, and in Linux 
is generally discouraged.  Vendor drivers in particular have a history 
of constantly getting this wrong, and it makes locking more difficult to 
review.

	Jeff