Subject: Re: [PATCH 1/4] atl1: Build files for Attansic L1 driver

From: Chris Snook <[email-masked]>
Date: Thu, 11 Jan 2007 04:31:41 -0500

Christoph Hellwig wrote:
> On Wed, Jan 10, 2007 at 06:40:51PM -0600, Jay Cliburn wrote:
>> --- /dev/null
>> +++ b/drivers/net/atl1/Makefile
>> @@ -0,0 +1,30 @@
>> +################################################################################
>> +#
>> +# Attansic L1 gigabit ethernet driver
>> +# Copyright(c) 2005 - 2006 Attansic Corporation.
>> +#
>> +# This program is free software; you can redistribute it and/or modify it
>> +# under the terms and conditions of the GNU General Public License,
>> +# version 2, as published by the Free Software Foundation.
>> +#
>> +# This program is distributed in the hope it will be useful, but WITHOUT
>> +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
>> +# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
>> +# more details.
>> +#
>> +# You should have received a copy of the GNU General Public License along with
>> +# this program; if not, write to the Free Software Foundation, Inc.,
>> +# 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
>> +#
>> +# The full GNU General Public License is included in this distribution in
>> +# the file called "COPYING".
>> +#
>> +################################################################################
> 
> I don't think anyone can claim copyright on two lines of actual kbuild code.
> 
>> +#
>> +# Makefile for the Attansic L1 gigabit ethernet driver
>> +#
> 
> This comment is antirely superflous.
> 
>> +obj-$(CONFIG_ATL1) += atl1.o
>> +
>> +atl1-objs := atl1_main.o atl1_hw.o atl1_ethtool.o atl1_param.o
> 
> Thi should be atl1-y += ...
> 
> In short the whole contents of this file should be:
> 
> ---------------- snip ----------------
> obj-$(CONFIG_ATL1)	+= atl1.o
> atl1-y			+= atl1_main.o atl1_hw.o atl1_ethtool.o atl1_param.o
> ---------------- snip ----------------
> 

Good point.  The original Attansic driver had a whole bunch of legacy 
compat crap, documentation build targets left over from e1000, etc. 
which we've been modifying and mostly just removing.  We don't really 
need this for merging.  If Attansic wants to maintain something out of 
tree for legacy kernels, they might want to reinsert this, but we really 
don't need it.

Thanks for pointing this out.

	-- Chris