From: Patrick McHardy <kaber@trash•net>
To: Jarek Poplawski <jarkao2@o2•pl>
Cc: netdev@vger•kernel.org, Stephen Hemminger <shemminger@osdl•org>
Subject: Re: [IPROUTE 02/05]: Introduce tc_calc_xmitsize and use where appropriate
Date: Mon, 15 Jan 2007 16:07:27 +0100 [thread overview]
Message-ID: <45AB98AF.5030401@trash.net> (raw)
In-Reply-To: <20070115123518.GA3124@ff.dom.local>
Jarek Poplawski wrote:
> On 10-01-2007 11:01, Patrick McHardy wrote:
>
>>[IPROUTE]: Introduce tc_calc_xmitsize and use where appropriate
>>
>>Add tc_calc_xmitsize() as complement to tc_calc_xmittime(), which calculates
>>the size that can be transmitted at a given rate during a given time.
>>
>>Replace all expressions of the form "size = rate*tc_core_tick2usec(time))/1000000"
>>by tc_calc_xmitsize() calls.
>>
>>Signed-off-by: Patrick McHardy <kaber@trash•net>
>>
>>---
>
> ...
>
>>+unsigned tc_calc_xmitsize(unsigned rate, unsigned ticks)
>>+{
>>+ return ((double)rate*tc_core_tick2usec(ticks))/1000000;
>>+}
>>+
>
>
> Actually, besides of replacing the expression, this function
> changes its type to unsigned also.
It doesn't change it, all expressions I replaced were directly
assigned to an unsigned int variable.
next prev parent reply other threads:[~2007-01-15 15:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-10 10:01 [IPROUTE 00/05]: Time cleanups Patrick McHardy
2007-01-10 10:01 ` [IPROUTE 01/05]: Use tc_calc_xmittime where appropriate Patrick McHardy
2007-01-16 8:56 ` Jarek Poplawski
2007-01-16 10:19 ` Patrick McHardy
2007-01-16 11:02 ` Jarek Poplawski
2007-01-16 12:28 ` Patrick McHardy
2007-01-16 12:48 ` Jarek Poplawski
2007-01-10 10:01 ` [IPROUTE 02/05]: Introduce tc_calc_xmitsize and use " Patrick McHardy
2007-01-15 12:35 ` Jarek Poplawski
2007-01-15 15:07 ` Patrick McHardy [this message]
2007-01-10 10:01 ` [IPROUTE 03/05]: Introduce TIME_UNITS_PER_SEC to represent internal clock resolution Patrick McHardy
2007-01-10 10:01 ` [IPROUTE 04/05]: Replace "usec" by "time" in function names Patrick McHardy
2007-01-15 10:17 ` Jarek Poplawski
2007-01-16 13:42 ` Patrick McHardy
2007-01-10 10:01 ` [IPROUTE 05/05]: Add sprint_ticks() function and use in CBQ Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2006-06-23 18:06 [RFC IPROUTE 00/05]: Time cleanups Patrick McHardy
2006-06-23 18:06 ` [IPROUTE 02/05]: Introduce tc_calc_xmitsize and use where appropriate Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45AB98AF.5030401@trash.net \
--to=kaber@trash$(echo .)net \
--cc=jarkao2@o2$(echo .)pl \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@osdl$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox