Subject: Re: [PATCH 2/7] cxgb3 - private ioctl cleanup

From: Divy Le Ray <[email-masked]>
Date: Thu, 22 Feb 2007 04:34:34 -0800

Hi Yoshfuji,
>> From: Divy Le Ray <[email-masked]>
>>
>> Clean up some private ioctls.
>>
>> Signed-off-by: Divy Le Ray <[email-masked]>
>> ---
>>
>>  drivers/net/cxgb3/cxgb3_ioctl.h |   21 ++++-------------
>>  drivers/net/cxgb3/cxgb3_main.c  |   48 +++------------------------------------
>>  2 files changed, 9 insertions(+), 60 deletions(-)
>>
>> diff --git a/drivers/net/cxgb3/cxgb3_ioctl.h b/drivers/net/cxgb3/cxgb3_ioctl.h
>> index a942818..42d4bf6 100644
>> --- a/drivers/net/cxgb3/cxgb3_ioctl.h
>> +++ b/drivers/net/cxgb3/cxgb3_ioctl.h
>> @@ -36,28 +36,17 @@
>>   * Ioctl commands specific to this driver.
>>   */
>>  enum {
>> -	CHELSIO_SETREG = 1024,
>> -	CHELSIO_GETREG,
>> -	CHELSIO_SETTPI,
>> -	CHELSIO_GETTPI,
>> -	CHELSIO_GETMTUTAB,
>> +	CHELSIO_GETMTUTAB = 1024,
>>  	CHELSIO_SETMTUTAB,
>> -	CHELSIO_GETMTU,
>> -	CHELSIO_SET_PM,
>> -	CHELSIO_GET_PM,
>> -	CHELSIO_GET_TCAM,
>> -	CHELSIO_SET_TCAM,
>> -	CHELSIO_GET_TCB,
>>  	CHELSIO_GET_MEM,
>>  	CHELSIO_LOAD_FW,
>> -	CHELSIO_GET_PROTO,
>> -	CHELSIO_SET_PROTO,
>>  	CHELSIO_SET_TRACE_FILTER,
>> -	CHELSIO_SET_QSET_PARAMS,
>>  	CHELSIO_GET_QSET_PARAMS,
>> -	CHELSIO_SET_QSET_NUM,
>> +	CHELSIO_SET_QSET_PARAMS,
>>  	CHELSIO_GET_QSET_NUM,
>> -	CHELSIO_SET_PKTSCHED,
>> +	CHELSIO_SET_QSET_NUM,
>> +	CHELSIO_GET_PM,
>> +	CHELSIO_SET_PM,
>>  };
>>  
>>     
>
> I disagree. This is very bad.
>
> 1. Please do do change the values.
> 2. Explain why you are going to kill these ioctls.
>   
Jeff and Arjan have required that most of these ioctls go.
Please read:
http://marc.theaimsgroup.com/?l=linux-netdev&m=117029584904193&w=2

Cheers,
Divy