Subject: Re: [PATCH 1/2] tc35815 driver update (part 1)

From: Jeff Garzik <[email-masked]>
Date: Fri, 02 Mar 2007 20:11:14 -0500

Atsushi Nemoto wrote:
> Current tc35815 driver is very obsolete and less maintained for a long
> time.  Replace it with a new driver based on one from CELF patch
> archive.  It was for 2.6.10 kernel so some adjustment and cleanup are
> added. (remove config.h, SA_ to IRQF_ conversion, etc.)
> 
> Major advantages are:
> 
> * Independent of JMR3927.
>   (Actually independent of MIPS, but AFAIK the chip is used only on
>    MIPS platforms)
> * TX4938 support.
> * 64-bit proof.
> * Asynchronous and on-demand auto negotiation.
> * High performance on non-coherent architecture.
> * ethtool support.
> * Many bugfixes and cleanups.
> 
> And next patch add further improvements/bugfixes/cleanups.
> 
> Signed-off-by: Atsushi Nemoto <[email-masked]>
> ---
> This is a patch against current linux-mips.org git-tree.
> 
>  drivers/net/Kconfig     |    3 
>  drivers/net/tc35815.c   | 2070 +++++++++++++++++++++++++++++++---------------
>  include/linux/pci_ids.h |    1 
>  3 files changed, 1440 insertions(+), 634 deletions(-)

Would you be kind enough to

a) provide a URL to a .c file (or post it, if it's under 100K) so that 
we may more easily review this

b) combine both patches into a single patch.  might as well, since it's 
a rewrite.

c) rediff your patch against linux-2.6.git + Ralf's killall removal 
patch, and resend.  There were some minor conflicting changes that 
appeared, though these changes will certainly become irrelevant once 
your new driver is merged.