Subject: Re: [patch 3/6] [TULIP] fix for Lite-On 82c168 PNIC

From: Jeff Garzik <[email-masked]>
Date: Thu, 15 Mar 2007 11:21:04 -0400

Valerie Henson wrote:
> From: Guido Classen <[email-masked]>
> 
> This small patch fixes two issues with the Lite-On 82c168 PNIC adapters.
> I've tested it with two cards in different machines both chip rev 17
> 
> The first is the wrong register address CSR6 for writing the MII register
> which instead is 0xB8 (this may get a symbol too?) (see similar exisiting code
> at line 437) in tulip_core.c
> 
> [Double-checked by Val Henson; yes, 0xB8 is correct register for
> autonegotiate on this card.]
> 
> At least by my cards, the the bit 31 from the MII register seems to be
> somewhat unstable. This results in reading wrong values from the Phy-Registers
> und prevents the card from correct initialization. I've added a litte delay
> and an second test of the bit. If the bit is stil cleared the read/write
> process has definitely finished.
> 
> [Original patch slightly massaged by Val Henson]
> 
> Signed-off-by: Val Henson <[email-masked]>
> Cc: Guido Classen <[email-masked]>
> Signed-off-by: Grant Grundler <[email-masked]>
> Cc: Jeff Garzik <[email-masked]>
> 
> ---
>  drivers/net/tulip/media.c      |   31 +++++++++++++++++++++++++++----
>  drivers/net/tulip/tulip_core.c |    4 ++--
>  2 files changed, 29 insertions(+), 6 deletions(-)

Seems sane, but now on HOLD while it's being discussed