Subject: Re: [PATCH] Netpoll support for Sibyte MAC

From: Sergei Shtylyov <[email-masked]>
Date: Tue, 20 Mar 2007 21:35:53 +0300

Hello.

Atsushi Nemoto wrote:

>>NETPOLL support for Sibyte MAC

>>Signed-off-by: Manish Lachwani <[email-masked]>
>>Signed-off-by: Deepak Saxena <[email-masked]>

> If you added NETPOLL support, do not forget to ensure hard_start_xmit
> routine callable from interrupt context (or irq disabled).
> See commit bce305f4fe779f29d99d414685243f5da0803254 for example.

    You're absolutely right: this driver is very likely to blow up the caller 
when called with interrupts disabled -- it uses spin_unlock_irq() there! This 
*must* be fixed.

> ---
> Atsushi Nemoto

WBR, Sergei