Subject: Re: [PATCH 5/5] [NETLINK]: Ignore control messages directly in netlink_run_queue()

From: Patrick McHardy <[email-masked]>
Date: Wed, 21 Mar 2007 13:06:23 +0100

Thomas Graf wrote:
> * Patrick McHardy <[email-masked]> 2007-03-21 05:44
> 
>>This looks like it would break nfnetlink, which appears to be
>>using 0 as smallest message type.
> 
> 
> It shouldn't do that, the first 16 message types are reserved
> for control messages.

I'm afraid it does:

enum cntl_msg_types {
        IPCTNL_MSG_CT_NEW,
        IPCTNL_MSG_CT_GET,
        IPCTNL_MSG_CT_DELETE,
        IPCTNL_MSG_CT_GET_CTRZERO,
        IPCTNL_MSG_MAX
};

This is totally broken of course since it also uses netlink_ack(),
netlink_dump() etc. :( Any smart ideas how to fix this without
breaking compatibility?