Subject: Re: [PATCH 19/19] e1000: major part of the new API changes

From: Stephen Hemminger <[email-masked]>
Date: Fri, 30 Mar 2007 13:19:37 -0700

>  
> +s32
> +e1000_alloc_zeroed_dev_spec_struct(struct e1000_hw *hw, u32 size)
> +{
> +	hw->dev_spec = kmalloc(size, GFP_KERNEL);
> +
> +	if (!hw->dev_spec)
> +		return -ENOMEM;
> +
> +	memset(hw->dev_spec, 0, size);
> +
> +	return E1000_SUCCESS;
> +}
>   

This is what is wrong with a lot of the new code. It is written as
verbose as possible.

What is wrong with open coded
    hw->dev_spec = kzalloc(size, GFP_KERNEL).
> +
> +void
> +e1000_free_dev_spec_struct(struct e1000_hw *hw)
> +{
> +	if (!hw->dev_spec)
> +		return;
> +
> +	kfree(hw->dev_spec);
> +}
> +
>   
Almost looks like you contracted this out to someone paid by the LOC.