Subject: Re: [Bugme-new] [Bug 8320] New: replacing route in kernel doesn't send netlink message

From: Patrick McHardy <[email-masked]>
Date: Wed, 18 Apr 2007 16:06:28 +0200

Milan Kocián wrote:
> On Tue, 2007-04-17 at 14:58 +0200, Patrick McHardy wrote:
> 
>>Milan, could you cook up another patch which uses NLM_F_REPLACE?
> 
> 
> I can try it. Output is in patch below. Review carefully. I don't know
> if it's best approach. It's tested and working without problem
> (probably :-))

Looks good, but your mailer corrupted long lines. Please resend as
attachment and sign off the patch.

> --- net/ipv4.old/fib_hash.c	2007-04-18 12:50:11.000000000 +0200
> +++ net/ipv4/fib_hash.c	2007-04-18 12:39:49.081369320 +0200
> @@ -443,7 +443,6 @@
>  		if (cfg->fc_nlflags & NLM_F_REPLACE) {
>  			struct fib_info *fi_drop;
>  			u8 state;
> -

And please drop this unrelated whitespace change.

> --- net/ipv4.old/fib_semantics.c	2007-04-18 12:50:11.000000000 +0200
> +++ net/ipv4/fib_semantics.c	2007-04-18 12:40:54.807377448 +0200
> @@ -301,7 +301,7 @@
>  }
>  
>  void rtmsg_fib(int event, __be32 key, struct fib_alias *fa,
> -	       int dst_len, u32 tb_id, struct nl_info *info)
> +	       int dst_len, u32 tb_id, struct nl_info *info, unsigned int
> nlm_flags)

This should go on a new line since it exceeds 80 characters.

> --- net/ipv4.old/fib_lookup.h	2007-04-18 12:50:11.000000000 +0200
> +++ net/ipv4/fib_lookup.h	2007-04-18 12:43:42.377902856 +0200
> @@ -30,7 +30,7 @@
>  			 int dst_len, u8 tos, struct fib_info *fi,
>  			 unsigned int);
>  extern void rtmsg_fib(int event, __be32 key, struct fib_alias *fa,
> -		      int dst_len, u32 tb_id, struct nl_info *info);
> +		      int dst_len, u32 tb_id, struct nl_info *info, unsigned int
> nlm_flags);

Same here.