Subject: Re: [PATCH 14/20][BNX2]: Re-structure the 2.5G Serdes code.

From: Jeff Garzik <[email-masked]>
Date: Wed, 02 May 2007 03:14:47 -0400

Michael Chan wrote:
> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
> index c6310ae..f2d248f 100644
> --- a/include/linux/ethtool.h
> +++ b/include/linux/ethtool.h
> @@ -434,6 +434,7 @@ struct ethtool_ops {
>  #define SUPPORTED_10000baseT_Full	(1 << 12)
>  #define SUPPORTED_Pause			(1 << 13)
>  #define SUPPORTED_Asym_Pause		(1 << 14)
> +#define SUPPORTED_2500baseX_Full	(1 << 15)
>  
>  /* Indicates what features are advertised by the interface. */
>  #define ADVERTISED_10baseT_Half		(1 << 0)
> @@ -451,6 +452,7 @@ struct ethtool_ops {
>  #define ADVERTISED_10000baseT_Full	(1 << 12)
>  #define ADVERTISED_Pause		(1 << 13)
>  #define ADVERTISED_Asym_Pause		(1 << 14)
> +#define ADVERTISED_2500baseX_Full	(1 << 15)

Please don't sneak in ethtool userspace API changes like this.  NAK.

The normal procedure for doing something like this is to create a 
separate patch and post it on netdev.  HOPEFULLY with the associated 
change to the ethtool(8) utility, to keep it in sync with the kernel. 
Otherwise, adding the above definition is useless to most users.  See 
http://sf.net/projects/gkernel/ or 
git://git.kernel.org/pub/scm/network/ethtool/ethtool.git for ethtool 
source code.

I ACK the changes to bnx2 outside of this, though.