Subject: Re: [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

From: "H. Peter Anvin" <[email-masked]>
Date: Wed, 16 May 2007 12:05:05 -0700

Rick Jones wrote:
> Some more of my paranoid questions :)
> 
> So, if a driver tries to enable MSI and that is unsuccessful (I'll try
> to avoid using the possibly loaded term "fails") shouldn't that show-up
> _somewhere_?

It already does -- in /proc/interrupts.

> Just how "normal" is an attempt to enable MSI not succeding
> going to remain over time and aren't there times when it does indeed
> mean that someone should be looking into it?

If we ever want a message, that should go in the general code and not in
each driver.

	-hpa