Subject: Re: [PATCH 3/5] ucc_geth: eliminate max-speed, change interface-type to phy-connection-type

From: Jeff Garzik <[email-masked]>
Date: Thu, 17 May 2007 21:53:37 -0400

Kim Phillips wrote:
> On Tue, 15 May 2007 17:45:19 -0400
> Jeff Garzik <[email-masked]> wrote:
> 
>> Kim Phillips wrote:
>>> It was agreed that phy-connection-type was a better name for
>>> the interface-type property, so this patch renames it.
>>>
>>> Also, the max-speed property name was determined too generic,
>>> and is therefore eliminated in favour of phy-connection-type
>>> derivation logic.
>>>
>>> includes corrections to copyright text.
>>>
>>> Signed-off-by: Kim Phillips <[email-masked]>
>>> ---
>>>  drivers/net/ucc_geth.c     |   40 ++++++++++++++++------------------------
>>>  drivers/net/ucc_geth_mii.c |    9 +++++----
>>>  drivers/net/ucc_geth_mii.h |   10 +++++-----
>>>  3 files changed, 26 insertions(+), 33 deletions(-)
>> applied to #upstream
>>
> just to be clear; only the mpc8323e-mds board works on your current #upstream-{fixes,linus}.
> 
> The mpc8323e-rdb and mpc8360e-mds require
> 
> phylib: add the ICPlus IP175C PHY driver
> 
> and 
> 
> phylib: enable RGMII-ID on the Marvell m88e1111 PHY
> 
> respectively in order to work.
> 
> I'm ok with the SGMII patches:
> 
> phylib: m88e1111: enable SGMII mode
> gianfar: add support for SGMII
> 
> staying on #upstream, but 2 out of 3 boards are currently broken for #upstream-{fixes,linus}.

New hardware support is always "broken" until merged.  Nonetheless it is 
still new and outside the merge window.

	Jeff