Subject: Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

From: Jeff Garzik <[email-masked]>
Date: Mon, 21 May 2007 19:42:39 -0400

Auke Kok wrote:
> Herbert Xu wrote:
> "netif_poll_enable can only be called if you've previously called
> netif_poll_disable.  Otherwise a poll might already be in action
> and you may get a crash like this."
> 
> Removing the call to netif_poll_enable in e1000_open should fix this issue,
> the only other call to netif_poll_enable is in e1000_up() which is only
> reached after a device reset or resume.
> 
> Bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=8455
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240339
> 
> Tested by Doug Chapman <[email-masked]>
> 
> Signed-off-by: Auke Kok <[email-masked]>
> Acked-by: Herbert Xu <[email-masked]>
> ---
> 
>  drivers/net/e1000/e1000_main.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)

applied, though as a poster (DaveJ?) noted, I'm not sure it completely 
fixes the bug