Subject: Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver

From: Marc St-Jean <[email-masked]>
Date: Thu, 24 May 2007 15:13:26 -0700

Jeff Garzik wrote:
> Marc St-Jean wrote:
>  > +inline static void
>  > +mspeth_skb_headerinit(struct sk_buff *skb)
>  > +{
>  > +     /* these are essential before init */
>  > +     dst_release(skb->dst);
>  > +#ifdef CONFIG_XFRM
>  > +     secpath_put(skb->sp);
>  > +#endif
>  > +#ifdef CONFIG_NETFILTER
>  > +     nf_conntrack_put(skb->nfct);
>  > +#if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE)
>  > +     nf_conntrack_put_reasm(skb->nfct_reasm);
>  > +#endif
>  > +#ifdef CONFIG_BRIDGE_NETFILTER
>  > +     nf_bridge_put(skb->nf_bridge);
>  > +#endif
>  > +#endif /* CONFIG_NETFILTER */
>  > +
>  > +     /*
>  > +      * Now initialise the skb...
>  > +      * Clear the members till skb->truesize.
>  > +      */
>  > +     memset(skb, 0, offsetof(struct sk_buff, truesize));
>  > +}
>  > +#endif /* CONFIG_MSPETH_SKB_RECYCLE */
> 
> Did you ever resend this driver addition, with the above unmaintainable
> skb init hacks removed?
> 
>         Jeff
> 

I removed the section you originally refererd to as it was associated with the
linux 2.4 support which was also removed.

I asked if the remaining section (above) was acceptable so we could retain our
buffer recycling which enhances throughput. I never received a rely so it was
left in my last patch.

The above comment now answers my part of my initial question. Are you aware of
a better way to implement this or must we lose all our recycling enhancements?

Thanks,
Marc