Subject: Re: [SKY2]: Fix VLAN unregistration

From: Ben Greear <[email-masked]>
Date: Mon, 28 May 2007 14:42:36 -0700

Patrick McHardy wrote:
> Fix sky2 disabling VLAN completely when the first vid is unregistered.
>
> For some reason the VLAN code insists on the driver providing a
> vlan_rx_kill_vid function even if only NETIF_F_HW_VLAN_RX and not
> NETIF_F_HW_VLAN_FILTER is set, so this patch keeps an empty
> function. This seems to be a bug though, vlan_rx_add_vid is only
> required with NETIF_F_HW_VLAN_FILTER. Ben?
>   
I believe DaveM did most of the vlan hw-accel work.  It would be easy 
enough to check
for a null function before calling the vlan_rx_kill_vid function and 
relax the checks
based on the flags, but there may be valid reasons to keep this as is.  
Perhaps
DaveM will comment...

Thanks,
Ben

-- 
Ben Greear <[email-masked]> 
Candela Technologies Inc  http://www.candelatech.com