Subject: Re: [PATCH 1/7] cxgb3 - Fix SGE page management

From: Jeff Garzik <[email-masked]>
Date: Mon, 28 May 2007 18:34:06 -0400

[email-masked] wrote:
> From: Divy Le Ray <[email-masked]>
> 
> Streamline page management on RX.
> Fix dma mappings.
> 
> Signed-off-by: Divy Le Ray <[email-masked]>

NAK #1:  "streamline" is not a bug-fixes-only change, which is the only 
type of change appropriate for 2.6.22-rc.

NAK #2:  You should use the page_address(page) accessor rather than 
creating a struct member in the same struct as your page, solely to 
contain the virtual address.