Subject: Re: [PATCH 4/7 RESEND] cxgb3 - Update FW to 4.1

From: Jeff Garzik <[email-masked]>
Date: Mon, 28 May 2007 18:41:15 -0400

[email-masked] wrote:
> From: Divy Le Ray <[email-masked]>
> 
> Bump FW version to 4.1.
> Modify chip tuning in consequence.
> 
> Signed-off-by: Divy Le Ray <[email-masked]>
> ---
> 
>  drivers/net/cxgb3/regs.h    |    4 ++++
>  drivers/net/cxgb3/t3_hw.c   |   40 ++++++++++++++++++++++------------------
>  drivers/net/cxgb3/version.h |    2 +-
>  3 files changed, 27 insertions(+), 19 deletions(-)

You think requiring a FIRMWARE UPGRADE is something that should be done 
in the middle of a kernel bugfix series?  What Q/A planet are you from?

This is a completely ridiculous burden you are placing on the individual 
user.  A good driver knows that firmware NOT SHIPPED WITH THE KERNEL 
does not necessarily move in lock-step with the kernel driver.  You are 
welcome to GPL your firmware and ship it of course....

	Jeff