From: Jeff Garzik <jeff@garzik•org>
To: Stephen Hemminger <shemminger@linux-foundation•org>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH 1/7] sky2: dont set bogus bit in PHY register
Date: Wed, 30 May 2007 09:53:01 -0400 [thread overview]
Message-ID: <465D81BD.5090505@garzik.org> (raw)
In-Reply-To: <20070524222538.375321658@linux-foundation.org>
Stephen Hemminger wrote:
> This code inherited from the sk98lin driver is incorrect on the Yukon2.
> The GPHY_CTRL register values are specific to the internal PHY of the chip
> and the values used were leftovers.
> Driver was setting bit 13 which is now the INT polarity for the PHY!
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation•org>
applied 1-3
next prev parent reply other threads:[~2007-05-30 13:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 22:22 [PATCH 0/7] sky2: patches for 2.6.22 Stephen Hemminger
2007-05-24 22:22 ` [PATCH 1/7] sky2: dont set bogus bit in PHY register Stephen Hemminger
2007-05-30 13:53 ` Jeff Garzik [this message]
2007-05-24 22:22 ` [PATCH 2/7] sky2: checksum offload plus vlan bug Stephen Hemminger
2007-05-24 22:22 ` [PATCH 3/7] sky2: program proper register for fiber PHY Stephen Hemminger
2007-05-24 22:22 ` [PATCH 4/7] sky2: PHY page register fixes Stephen Hemminger
2007-05-30 13:59 ` Jeff Garzik
2007-05-24 22:22 ` [PATCH 5/7] sky2: enable IRQ on duplex renegotiation Stephen Hemminger
2007-05-30 13:54 ` Jeff Garzik
2007-05-24 22:22 ` [PATCH 6/7] sky2: enable clocks before probe Stephen Hemminger
2007-05-30 13:56 ` Jeff Garzik
2007-05-30 14:43 ` Stephen Hemminger
2007-05-30 17:45 ` Stephen Hemminger
2007-05-24 22:22 ` [PATCH 7/7] sky2: version 1.15 Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465D81BD.5090505@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox