From: Jeff Garzik <jeff@garzik•org>
To: Stephen Hemminger <shemminger@linux-foundation•org>
Cc: David Miller <davem@davemloft•net>,
Patrick McHardy <kaber@trash•net>,
Ben Greear <greearb@candelatech•com>,
netdev@vger•kernel.org
Subject: Re: [PATCH 1/5] VLAN: kill_vid is only useful for VLAN filtering devices
Date: Sun, 03 Jun 2007 11:47:34 -0400 [thread overview]
Message-ID: <4662E296.5010505@garzik.org> (raw)
In-Reply-To: <20070601164705.300415731@linux-foundation.org>
Stephen Hemminger wrote:
> The interface for network device VLAN extension was confusing.
> The kill_vid function is only really useful for devices that do
> hardware filtering. Devices that only do VLAN receiption without
> filtering were being forced to provide the hook, and there were
> bugs in those devices.
>
> Many drivers had kill_vid routine that called vlan_group_set_device, with
> NULL, but that is done already.
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation•org>
applied 1-5 to #upstream-fixes
prev parent reply other threads:[~2007-06-03 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070601164356.673375550@linux-foundation.org>
2007-06-01 17:12 ` [PATCH 0/5] VLAN driver API fixes Patrick McHardy
[not found] ` <20070601164705.586224195@linux-foundation.org>
2007-06-01 18:04 ` [PATCH 4/5] atl1: eliminate unneeded kill_vid code Chris Snook
[not found] ` <20070601164705.300415731@linux-foundation.org>
2007-06-03 15:47 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4662E296.5010505@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=greearb@candelatech$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox