From: Patrick McHardy <kaber@trash•net>
To: Herbert Xu <herbert@gondor•apana.org.au>
Cc: "David S. Miller" <davem@davemloft•net>, netdev@vger•kernel.org
Subject: Re: [PATCH 3/4] [IPV4]: Add default config support after inetdev_init
Date: Mon, 11 Jun 2007 14:26:58 +0200 [thread overview]
Message-ID: <466D3F92.7050803@trash.net> (raw)
In-Reply-To: <E1HvSZL-0003AB-00@gondolin.me.apana.org.au>
Herbert Xu wrote:
> [IPV4]: Add default config support after inetdev_init
>
> Previously once inetdev_init has been called on a device any changes made
> to ipv4_devconf_dflt would have no effect on that device's configuration.
I noticed a few more side-effects from the original change that
seem to be undesired. Some code assumes that dev->ip_ptr != NULL
implies existance of IP addresses on the device. For example
fib_check_nh used to allow to add routes to devices only when a
in_device is present. We can now add routes without having any
IP addresses configured, which makes routing choose 0.0.0.0 as
source and invalidates the assumption of some other code that
the outgoing device of a packet always has an in_device present
(like MASQUERADE). fib_sync_up used to skip a nexthop when no
IP addresses was present on the device, now it will keep it.
There's probably more, I guess we need to audit all in_dev_get
calls.
next prev parent reply other threads:[~2007-06-11 12:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-02 10:01 [0/4] [IPV4]: Fix compatibility issue with ipv4_devconf_dflt Herbert Xu
2007-06-02 10:02 ` [1/4] [IPV4]: Only panic if inetdev_init fails for loopback Herbert Xu
2007-06-02 10:02 ` [2/4] [IPV4]: Convert IPv4 devconf to an array Herbert Xu
2007-06-02 11:47 ` jamal
2007-06-05 6:17 ` David Miller
2007-06-05 6:29 ` Herbert Xu
2007-06-05 6:31 ` [PATCH 1/4] [IPV4]: Only panic if inetdev_init fails for loopback Herbert Xu
2007-06-05 6:34 ` David Miller
2007-06-05 6:31 ` [PATCH 2/4] [IPV4]: Convert IPv4 devconf to an array Herbert Xu
2007-06-05 6:34 ` David Miller
2007-06-05 6:31 ` [PATCH 3/4] [IPV4]: Add default config support after inetdev_init Herbert Xu
2007-06-05 6:35 ` David Miller
2007-06-11 12:26 ` Patrick McHardy [this message]
2007-06-11 12:31 ` Herbert Xu
2007-06-05 6:31 ` [PATCH 4/4] [IPV4]: Restore old behaviour of default config values Herbert Xu
2007-06-05 6:36 ` David Miller
2007-06-02 10:03 ` [3/4] [IPV4]: Add default config support after inetdev_init Herbert Xu
2007-06-02 10:03 ` [4/4] [IPV4]: Restore old behaviour of default config values Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466D3F92.7050803@trash.net \
--to=kaber@trash$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox