Subject: Re: [PATCH 4/15] spidernet: silence the ramfull messages

From: Jeff Garzik <[email-masked]>
Date: Wed, 13 Jun 2007 16:12:00 -0400

Linas Vepstas wrote:
> --- linux-2.6.22-rc1.orig/drivers/net/spider_net.c	2007-06-11 10:02:34.000000000 -0500
> +++ linux-2.6.22-rc1/drivers/net/spider_net.c	2007-06-11 11:45:25.000000000 -0500
> @@ -1172,7 +1172,7 @@ spider_net_decode_one_descr(struct spide
>  		goto bad_desc;
>  	}
>  
> -	if (hwdescr->dmac_cmd_status & 0xfefe) {
> +	if (hwdescr->dmac_cmd_status & 0xfcf4) {
>  		pr_err("%s: bad status, cmd_status=x%08x\n",
>  			       card->netdev->name,
>  			       hwdescr->dmac_cmd_status);

A follow-up patch needs to remove the above magic numbers (==numeric 
constants), replacing them with named constants

I only accepted the above patch because it was needed for the fixes. 
Otherwise I would have requested a SPIDERNET_BAD_STATUS constant or 
similar, containing the relevant split-out bits