Subject: Re: [PATCH 10/21] r8169: merge with version 6.001.00 of Realtek's r8169 driver

From: Jeff Garzik <[email-masked]>
Date: Sat, 30 Jun 2007 05:47:40 -0400

Francois Romieu wrote:
> Jeff Garzik <[email-masked]> :
>> Arjan van de Ven wrote:
>>>> +	pci_write_config_byte(tp->pci_dev, PCI_LATENCY_TIMER, 0x40);
>>> can you create a pci_set_latency_timer() for this please?
> [...]
>>>> +	if (tp->mac_version <= RTL_GIGA_MAC_VER_06)
>>>> +		pci_write_config_byte(tp->pci_dev, PCI_CACHE_LINE_SIZE, 
>>>> 0x08);
>>> and something for this as well?
>> Why?  Nothing here seems generic to me.
> 
> I.e. no need for pci_set_latency_timer(struct pci_dev *dev, u8 latency)
> neither pci_set_cache_line_size(struct pci_dev *dev, u8 size) ?

Yeah.  When it gets to be a one-line wrapper like that, I don't see much 
additional value in pci_set_cache_line_size() over 
pci_write_config_byte(,PCI_CACHE_LINE_SIZE,).

	Jeff