Subject: Re: [PATCH 2.6.22 2/4]S2IO: Removing MSI support from the driver

From: Jeff Garzik <[email-masked]>
Date: Mon, 02 Jul 2007 08:18:00 -0400

Veena Parat wrote:
> 1.Removed MSI support from driver - unused feature
> 2.Removed pci_request_regions call to allocate bar2 as it is not used in driver
> 3.Removed pci_release_regions since pci_request_regions is not done

This is wrong.  pci_request_regions() grabs all the regions for the 
associated PCI device, which is the desired behavior.

Using request_mem_region() is not what you want to do for PCI devices.