Subject: Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

From: Arjan van de Ven <[email-masked]>
Date: Mon, 02 Jul 2007 07:05:30 -0700

>> +    u32 alloc_rx_buff_failed;
>> +    struct {
>> +        unsigned int rx_csum_enabled    :1;
>> +        unsigned int msi_capable    :1;
>> +        unsigned int msi_enabled    :1;
>> +        unsigned int msix_capable    :1;
>> +        unsigned int msix_enabled    :1;
>> +        unsigned int imir_enabled    :1;
>> +        unsigned int in_netpoll        :1;
>> +    } flags;
> 
> always avoid bitfields.  They generate horrible code, and endian 
> problems abound (though no endian problems are apparent here).

they generate no worse code than open coding the checks for these 
feature flags...