Subject: Re: [PATCH -mm 7/9] netconsole: Support multiple logging targets

From: KII Keiichi <[email-masked]>
Date: Sun, 08 Jul 2007 03:33:49 +0900

Hi Satyam,

The following comments aren't essential.

>  	if (!(event == NETDEV_UP || event == NETDEV_DOWN ||
>  	      event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
> -	      	goto done;
> +		goto done;

The above diff lines are extra.

> +	spin_lock_irqsave(&target_list_lock, flags);
> +	list_for_each_entry(nt, &target_list, list) {
> +		if (nt->np.dev == dev) {
> +			switch (event) {
> +			case NETDEV_UP:
> +			case NETDEV_DOWN:
> +				nt->dev_status = net_dev_is_up(nt->np.dev);
> +				break;
> +
> +			case NETDEV_CHANGEADDR:
> +				memcpy(nt->np.local_mac, dev->dev_addr, ETH_ALEN);

The above line is over 80 characters.

Thanks,
-- 
Keiichi KII
NEC Corporation OSS Platform Development Division
E-mail: [email-masked]