From: Jeff Garzik <jeff@garzik•org>
To: Linas Vepstas <linas@austin•ibm.com>
Cc: netdev@vger•kernel.org, cbe-oss-dev@ozlabs•org,
Kou Ishizaki <kou.ishizaki@toshiba•co.jp>
Subject: Re: [PATCH] spidernet: improve interrupt handling
Date: Tue, 10 Jul 2007 12:25:28 -0400 [thread overview]
Message-ID: <4693B2F8.3070702@garzik.org> (raw)
In-Reply-To: <20070709231742.GQ4457@austin.ibm.com>
Linas Vepstas wrote:
> From: Ishizaki Kou <kou.ishizaki@toshiba•co.jp>
>
> We intend this patch to improve spidernet interrupt handling to be
> more strict. We had following problem and this patch solves it.
>
> -when CONFIG_DEBUG_SHIRQ=y, request_irq() calls handler().
> -when spider_net_open() is called, it calls request_irq() which calls
> spider_net_interrupt().
> -if some specific interrupt bit is set at this timing, it calls
> netif_rx_schedule() and spider_net_poll() is scheduled.
> -spider_net_open() calls netif_poll_enable() which clears the bit
> __LINK_STATE_RX_SCHED.
> -when spider_net_poll() is called, it calls netif_rx_complete() which
> causes BUG_ON() because __LINK_STATE_RX_SCHED is not set.
>
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba•co.jp>
> Signed-off-by: Linas Vepstas <linas@austin•ibm.com>
>
> ----
> Jeff, please apply for 2.6.23
>
> Linas.
>
> drivers/net/spider_net.c | 59 +++++++++++++++++++++++++++++++++++------------
> 1 file changed, 45 insertions(+), 14 deletions(-)
>
applied
next prev parent reply other threads:[~2007-07-10 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 23:17 [PATCH] spidernet: improve interrupt handling Linas Vepstas
2007-07-10 16:25 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-07-09 8:48 Ishizaki Kou
2007-07-09 22:19 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4693B2F8.3070702@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=cbe-oss-dev@ozlabs$(echo .)org \
--cc=kou.ishizaki@toshiba$(echo .)co.jp \
--cc=linas@austin$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox