Subject: Re: [PATCH 2/4] Add new timeval_to_sec function

From: Varun Chandramohan <[email-masked]>
Date: Tue, 24 Jul 2007 09:45:47 +0530

Patrick McHardy wrote:
> Varun Chandramohan wrote:
>   
>>  /**
>> + * timeval_to_sec - Convert timeval to seconds
>> + * @tv:         pointer to the timeval variable to be converted
>> + *
>> + * Returns the seconds representation of timeval parameter.
>> + */
>> +static inline time_t timeval_to_sec(const struct timeval *tv)
>> +{
>> +	return (tv->tv_sec + (tv->tv_usec + 500000)/1000000);
>> +}
>>     
>
>
> I don't think you should round down timeout values.
>   
Can you elaborate on that? As per the RFC of MIB ,we need only seconds
granularity. Taking that as the case i dont understand why round down
should not be done?

Regards,
Varun