From: Patrick McHardy <kaber@trash•net>
To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel•com>
Cc: netdev@vger•kernel.org
Subject: Re: Tc filtering: broken 802_3 classifier?
Date: Wed, 25 Jul 2007 19:28:47 +0200 [thread overview]
Message-ID: <46A7884F.70707@trash.net> (raw)
In-Reply-To: <D5C1322C3E673F459512FB59E0DDC329034BF7D3@orsmsx414.amr.corp.intel.com>
Waskiewicz Jr, Peter P wrote:
>>The protocol match is on skb->protocol, so it case of
>>ethernet its on the ethernet protocol, which is ETH_P_IP or
>>"ip" for IPv4.
>
>
> I see that in the code, but the reason I started worrying was when I
> added the 802_3 classifier on 8 flows, it would shove all traffic into
> flowid 1:1, no matter if it matched or not.
>
> I'll keep investigating and see if I can narrow down what I'm seeing.
I'm not sure what you're expecting. skb->protocol is usually not set
to ETH_P_802_3, which is why the filter is not matching.
next prev parent reply other threads:[~2007-07-25 17:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 0:19 Tc filtering: broken 802_3 classifier? Waskiewicz Jr, Peter P
2007-07-25 0:31 ` Patrick McHardy
2007-07-25 17:24 ` Waskiewicz Jr, Peter P
2007-07-25 17:28 ` Patrick McHardy [this message]
2007-07-25 17:34 ` Waskiewicz Jr, Peter P
2007-07-25 23:11 ` Patrick McHardy
2007-07-25 23:34 ` Waskiewicz Jr, Peter P
2007-07-25 23:40 ` Patrick McHardy
2007-07-25 23:58 ` Patrick McHardy
2007-07-26 0:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A7884F.70707@trash.net \
--to=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peter.p.waskiewicz.jr@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox