From: Eric Dumazet <dada1@cosmosbay•com>
To: Varun Chandramohan <varunc@linux•vnet.ibm.com>
Cc: davem@davemloft•net, netdev@vger•kernel.org, kaber@trash•net,
socketcan@hartkopp•net, shemminger@linux-foundation•org,
krkumar2@in•ibm.com
Subject: Re: [PATCH 2/4 -rev1] Add new timeval_to_sec function
Date: Thu, 26 Jul 2007 07:58:22 +0200 [thread overview]
Message-ID: <46A837FE.5060900@cosmosbay.com> (raw)
In-Reply-To: <20070726104526.0348e746.varunc@linux.vnet.ibm.com>
Varun Chandramohan a écrit :
> A new function for converting timeval to time_t is added in time.h. Its a common function used in different
> places. The timeout is now rounded up as per the suggestion.
>
> Signed-off-by: Varun Chandramohan <varunc@linux•vnet.ibm.com>
> ---
> include/linux/time.h | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/time.h b/include/linux/time.h
> index dda9be6..908329a 100644
> --- a/include/linux/time.h
> +++ b/include/linux/time.h
> @@ -147,6 +147,17 @@ static inline s64 timeval_to_ns(const st
> }
>
> /**
> + * timeval_to_sec - Convert timeval to seconds
> + * @tv: pointer to the timeval variable to be converted
> + *
> + * Returns the seconds representation of timeval parameter.
> + */
> +static inline time_t timeval_to_sec(const struct timeval *tv)
> +{
> + return (tv->tv_sec + (tv->tv_usec + 999999)/1000000);
> +}
> +
> +/**
return tv->tv_sec + (tv->tv_usec ? 1 : 0);
is much faster
Also, the comment is not accurate, as it doesnt mention the roundup at all.
next prev parent reply other threads:[~2007-07-26 5:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 5:15 [PATCH 2/4 -rev1] Add new timeval_to_sec function Varun Chandramohan
2007-07-26 5:58 ` Eric Dumazet [this message]
2007-07-26 6:17 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A837FE.5060900@cosmosbay.com \
--to=dada1@cosmosbay$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kaber@trash$(echo .)net \
--cc=krkumar2@in$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@linux-foundation$(echo .)org \
--cc=socketcan@hartkopp$(echo .)net \
--cc=varunc@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox