Subject: Re: [PATCH 1/1]ixgbe: Driver for Intel 82598 based 10GbE PCI Express family of adapters

From: Jeff Garzik <[email-masked]>
Date: Fri, 27 Jul 2007 09:52:02 -0400

Stephen Hemminger wrote:
> Using module parameter for per device settings is bad idea.
> Please extend existing interfaces like ethtool, etc rather than committing
> to a bad inflexible API.

I agreed with Stephen's comments here.

In general, net driver policy is to use ethtool (per-interface 
granularity) rather than module options.

	Jeff