From: Simon Arlott <simon@fire•lp0.eu>
To: Ayaz Abdulla <aabdulla@nvidia•com>
Cc: Jeff Garzik <jgarzik@pobox•com>,
Manfred Spraul <manfred@colorfullife•com>,
Andrew Morton <akpm@osdl•org>,
netdev@vger•kernel.org
Subject: Re: [PATCH] forcedeth: mac address correct
Date: Sat, 28 Jul 2007 00:50:10 +0100 [thread overview]
Message-ID: <46AA84B2.4030305@simon.arlott.org.uk> (raw)
In-Reply-To: <46A96798.5000106@nvidia.com>
On 27/07/07 04:33, Ayaz Abdulla wrote:
> In older chipsets, the mac address was stored in reversed order.
> However, in newer chipsets, the mac address is in correct order. This
> patch takes those newer chipsets into account and does not rely on a
> special bit setup by BIOS'.
>
> Signed-Off-By: Ayaz Abdulla <aabdulla@nvidia•com>
>
>
- if (txreg & NVREG_TRANSMITPOLL_MAC_ADDR_REV) {
+ if ((txreg & NVREG_TRANSMITPOLL_MAC_ADDR_REV) ||
+ (id->driver_data & DEV_HAS_CORRECT_MACADDR) {
This will not compile.
--
Simon Arlott
next prev parent reply other threads:[~2007-07-27 23:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-27 3:33 [PATCH] forcedeth: mac address correct Ayaz Abdulla
2007-07-27 23:50 ` Simon Arlott [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-07-27 3:46 Ayaz Abdulla
2007-07-30 19:50 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AA84B2.4030305@simon.arlott.org.uk \
--to=simon@fire$(echo .)lp0.eu \
--cc=aabdulla@nvidia$(echo .)com \
--cc=akpm@osdl$(echo .)org \
--cc=jgarzik@pobox$(echo .)com \
--cc=manfred@colorfullife$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox