From: Or Gerlitz <ogerlitz@voltaire•com>
To: "Michael S. Tsirkin" <mst@dev•mellanox.co.il>
Cc: netdev@vger•kernel.org, Roland Dreier <rdreier@cisco•com>,
fubar@us•ibm.com, davem@davemloft•net,
general@lists•openfabrics.org
Subject: [ofa-general] Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for the bonding driver
Date: Tue, 31 Jul 2007 17:57:46 +0300 [thread overview]
Message-ID: <46AF4DEA.9050202@voltaire.com> (raw)
In-Reply-To: <20070731144827.GB17331@mellanox.co.il>
Michael S. Tsirkin wrote:
>> Quoting Or Gerlitz <ogerlitz@voltaire•com>:
>> Michael S. Tsirkin wrote:
>>> It's always wrong to copy symbols from another module without
>>> referencing it.
>> Its the --first-- time you make this comment,
> It's really a well known fact. That's where the crash
> with modprobe -r comes from, right?
no, the crash --only-- comes from the neighbour cleanup function being
called while ipoib is now probed out of the kernel. The other symbols
are not problematic. I got positive feedback that this --is-- the
problem in the previous posts and from Roland during my Sonoma presentation.
>> please suggest a different approach,
> I don't know, really - if you want to access a module, you really must get
> a reference to it, or to the device.
> How about adding the module pointer to struct net_device?
I think there used to be there owner field of type struct module and it
was removed... we will check that.
>> the relevant code is below.
>
>> +static void bond_setup_by_slave(struct net_device *bond_dev,
>> + struct net_device *slave_dev)
>> +{
>> + bond_dev->hard_header = slave_dev->hard_header;
>> + bond_dev->rebuild_header = slave_dev->rebuild_header;
>> + bond_dev->hard_header_cache = slave_dev->hard_header_cache;
>> + bond_dev->header_cache_update = slave_dev->header_cache_update;
>> + bond_dev->hard_header_parse = slave_dev->hard_header_parse;
>> +
>> + bond_dev->neigh_setup = slave_dev->neigh_setup;
>> +
>> + bond_dev->type = slave_dev->type;
>> + bond_dev->hard_header_len = slave_dev->hard_header_len;
>> + bond_dev->addr_len = slave_dev->addr_len;
>> +
>> + memcpy(bond_dev->broadcast, slave_dev->broadcast,
>> + slave_dev->addr_len);
>> +}
>> +
>
> Hmm, it seems that switching to hard_header_cache as I suggested won't help at all.
why? please clarify.
> I wonder: is bonding currently broken with devices that implement
> hard_header_cache/header_cache_update?
I don't think so. Note that bond_setup_by_slave is only called for
slaves whose ether type is --not-- Ethernet.
Or.
next prev parent reply other threads:[~2007-07-31 14:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 12:37 [ofa-general] [PATCH V3 0/7] net/bonding: ADD IPoIB support for the bonding driver Moni Shoua
2007-07-30 12:48 ` [ofa-general] [PATCH V3 1/7] IB/ipoib: Bound the net device to the ipoib_neigh structue Moni Shoua
2007-07-30 12:49 ` [ofa-general] [PATCH V3 2/7] IB/ipoib: Verify address handle validity on send Moni Shoua
2007-07-30 12:51 ` [ofa-general] [PATCH V3 3/7] net/bonding: Enable bonding to enslave non ARPHRD_ETHER Moni Shoua
2007-07-30 12:52 ` [ofa-general] [PATCH V3 4/7] net/bonding: Enable bonding to enslave netdevices not supporting set_mac_address() Moni Shoua
2007-07-30 12:54 ` [ofa-general] [PATCH V3 5/7] net/bonding: Enable IP multicast for bonding IPoIB devices Moni Shoua
2007-07-30 12:54 ` [ofa-general] [PATCH V3 6/7] net/bonding: Handlle wrong assumptions that slave is always an Ethernet device Moni Shoua
2007-07-30 12:56 ` [ofa-general] [PATCH V3 7/7] net/bonding: Delay sending of gratuitous ARP to avoid failure Moni Shoua
2007-07-30 20:29 ` [ofa-general] " Jay Vosburgh
2007-07-31 13:33 ` Moni Shoua
2007-07-30 21:20 ` [PATCH V3 0/7] net/bonding: ADD IPoIB support for the bonding driver Roland Dreier
2007-07-31 13:44 ` [ofa-general] " Moni Shoua
2007-07-31 14:04 ` [ofa-general] " Michael S. Tsirkin
2007-07-31 14:19 ` Or Gerlitz
2007-07-31 14:22 ` [ofa-general] " Michael S. Tsirkin
2007-07-31 14:36 ` Or Gerlitz
2007-07-31 14:48 ` Michael S. Tsirkin
2007-07-31 14:57 ` Or Gerlitz [this message]
2007-08-01 14:12 ` [ofa-general] Re: Re: " Moni Shoua
2007-08-01 16:10 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AF4DEA.9050202@voltaire.com \
--to=ogerlitz@voltaire$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fubar@us$(echo .)ibm.com \
--cc=general@lists$(echo .)openfabrics.org \
--cc=mst@dev$(echo .)mellanox.co.il \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rdreier@cisco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox