From: Patrick McHardy <kaber@trash•net>
To: Joakim Koskela <joakim.koskela@hiit•fi>
Cc: netdev@vger•kernel.org, David Miller <davem@davemloft•net>
Subject: Re: [PATCH net-2.6.22-rc7] xfrm beet interfamily support
Date: Mon, 06 Aug 2007 14:08:12 +0200 [thread overview]
Message-ID: <46B70F2C.6090807@trash.net> (raw)
In-Reply-To: <200708060949.58758.joakim.koskela@hiit.fi>
Joakim Koskela wrote:
> On Tuesday 17 July 2007 17:30:21 Joakim Koskela wrote:
>
>>>>@@ -108,7 +108,8 @@ int xfrm4_rcv_encap(struct sk_buff *skb, __u16
>>>>encap_type) if (x->mode->input(x, skb))
>>>> goto drop;
>>>>
>>>>- if (x->props.mode == XFRM_MODE_TUNNEL) {
>>>>+ if (x->props.mode == XFRM_MODE_TUNNEL ||
>>>>+ x->props.mode == XFRM_MODE_BEET) {
>>>> decaps = 1;
>>>> break;
>>>> }
>>>
> It's been a while, but as a fyi in case there are comments / suggestions
> before submitting the whole patch again - it seems that this had some
> problems after all. Works ok for normal cases, but fails when using ip
> options for the inner packet as they don't get processed after being
> extracted from the pseudoheader. Calling something like ip_options_compile
> from beet_mode's input when handling ipv4 would do the trick, but seems a bit
> ugly & perhaps unsafe, I'd rather just put the whole packet through the loop
> again.
Won't the options get parsed by ip_rcv() on the second reception?
next prev parent reply other threads:[~2007-08-06 12:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 12:06 [PATCH net-2.6.22-rc7] xfrm beet interfamily support Joakim Koskela
2007-07-16 12:56 ` Arnaldo Carvalho de Melo
2007-07-18 9:18 ` David Miller
2007-07-16 18:47 ` Patrick McHardy
2007-07-17 14:30 ` Joakim Koskela
2007-07-17 16:00 ` Patrick McHardy
2007-07-19 14:08 ` Joakim Koskela
2007-07-19 14:46 ` Patrick McHardy
2007-07-19 17:54 ` Joakim Koskela
2007-07-19 19:43 ` Patrick McHardy
2007-07-23 16:19 ` [PATCH net-2.6.22-rc7] xfrm state selection update to use inner addresses Joakim Koskela
2007-07-24 14:31 ` Patrick McHardy
2007-07-26 7:08 ` David Miller
2007-07-31 10:39 ` [PATCH net-2.6.22-rc7] xfrm beet interfamily support Joakim Koskela
2007-07-31 10:51 ` Patrick McHardy
2007-07-31 11:08 ` Joakim Koskela
2007-07-31 11:14 ` Patrick McHardy
2007-07-31 12:13 ` Joakim Koskela
2007-08-06 6:49 ` Joakim Koskela
2007-08-06 12:08 ` Patrick McHardy [this message]
2007-08-06 13:07 ` Joakim Koskela
2007-08-06 13:21 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2007-07-12 9:25 Joakim Koskela
2007-07-15 1:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B70F2C.6090807@trash.net \
--to=kaber@trash$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=joakim.koskela@hiit$(echo .)fi \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox