Subject: Re: [PATCH] e1000e: New pci-express e1000 driver (currently for ICH9 devices only)

From: "Kok, Auke" <[email-masked]>
Date: Mon, 06 Aug 2007 21:25:05 -0700

Andi Kleen wrote:
> "Kok, Auke" <[email-masked]> writes:
> 
>> All,
>>
>> Another update on e1000e. Many thanks to Jeff for helping out and
>> getting this going forward. The driver is unfortunately still too
>> large to post, so please use the URL's below to review:
> 
> Just some things I noticed; no comprehensive review

thanks, quick reply to one of the issues below, others I'll take into account 
and look into deeper.

> +       mod_timer(&adapter->blink_timer, jiffies + E1000_ID_INTERVAL);
> Should use round_jiffies to avoid wakeups

actually, not here - we don't want the led to blink unreliably. If the timer 
gets stalled beyond 1/2 a second and is irregular, you'll never be able to 
identify the proper adapter port in you data center.

remember, this is only used once the user invokes 'ethtool -p'

Auke