Subject: Re: [PATCH 1/4] Net: mac80211, remove bitfields from struct ieee80211_tx_packet_data

From: Jiri Slaby <[email-masked]>
Date: Mon, 13 Aug 2007 21:59:19 +0200

Johannes Berg napsal(a):
> On Sun, 2007-08-12 at 15:08 +0200, Jiri Slaby wrote:
> 
>> +	if (control->flags & IEEE80211_TXCTL_REQ_TX_STATUS)
>> +		pkt_data->flags |= IEEE80211_TXPD_REQ_TX_STATUS;
>> +	if (control->flags & IEEE80211_TXCTL_DO_NOT_ENCRYPT)
>> +		pkt_data->flags |= IEEE80211_TXPD_DO_NOT_ENCRYPT;
>> +	if (control->flags & IEEE80211_TXCTL_REQUEUE)
>> +		pkt_data->flags |= IEEE80211_TXPD_REQUEUE;
>> +	if (control->type == IEEE80211_IF_TYPE_MGMT)
>> +		pkt_data->flags |= IEEE80211_TXPD_MGMT_IFACE;
> 
> This looks weird. Can't we just use the same flags?

I don't think, that it must be subset one of each another in the future. (This
is why I created yet another bits defined).

Do we still want the same flags?

-- 
Jiri Slaby ([email-masked])
Faculty of Informatics, Masaryk University