From: Jeff Garzik <jeff@garzik•org>
To: Auke Kok <auke-jan.h.kok@intel•com>
Cc: netdev@vger•kernel.org, akpm@linux-foundation•org, andi@firstfloor•org
Subject: Re: [PATCH 2/6] e1000e: remove namespace collisions with e1000
Date: Tue, 14 Aug 2007 01:13:26 -0400 [thread overview]
Message-ID: <46C139F6.2040007@garzik.org> (raw)
In-Reply-To: <20070810200047.21509.46779.stgit@localhost.localdomain>
Auke Kok wrote:
> To prevent future collisions we rename all extern's from e1000_
> to e1000e_*. The list of changed symbols was taken from e1000.h
> Compile tested with CONFIG_E1000=y and CONFIG_E1000E=y.
>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel•com>
> ---
>
> drivers/net/e1000e/82571.c | 129 +++++++++++++-------------
> drivers/net/e1000e/e1000.h | 194 +++++++++++++++++++--------------------
> drivers/net/e1000e/es2lan.c | 118 ++++++++++++------------
> drivers/net/e1000e/ethtool.c | 62 ++++++------
> drivers/net/e1000e/ich8lan.c | 92 +++++++++---------
> drivers/net/e1000e/lib.c | 210 +++++++++++++++++++++---------------------
> drivers/net/e1000e/netdev.c | 168 +++++++++++++++++-----------------
> drivers/net/e1000e/param.c | 8 +-
> drivers/net/e1000e/phy.c | 138 ++++++++++++++--------------
> 9 files changed, 559 insertions(+), 560 deletions(-)
if you grep around this effort was already started using the 'e1e_'
prefix. I like the shorter prefix, but your call ultimately. Either
way, make sure to make the driver consistent there too.
e1e_flush(), e1e_wphy(), etc.
Overall I still want to push the driver towards shorter function and
variable names. Things like
e1000e_get_speed_and_duplex_fiber_serdes are just way too long.
Jeff
next prev parent reply other threads:[~2007-08-14 5:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 20:00 [PATCH 1/6] e1000e: Fix header includes [v2] Auke Kok
2007-08-10 20:00 ` [PATCH 2/6] e1000e: remove namespace collisions with e1000 Auke Kok
2007-08-14 5:13 ` Jeff Garzik [this message]
2007-08-14 16:41 ` Rick Jones
2007-08-14 21:22 ` Kok, Auke
2007-08-10 20:00 ` [PATCH 3/6] e1000e: Use dma_alloc_coherent where possible Auke Kok
2007-08-10 20:00 ` [PATCH 4/6] e1000e: Use time_after to account for jiffies wrapping Auke Kok
2007-08-10 20:01 ` [PATCH 5/6] e1000e: error handling for pci_map_single calls Auke Kok
2007-08-14 5:15 ` Jeff Garzik
2007-08-10 20:01 ` [PATCH 6/6] e1000e: Remove two compile warnings Auke Kok
2007-08-14 5:11 ` [PATCH 1/6] e1000e: Fix header includes [v2] Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C139F6.2040007@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andi@firstfloor$(echo .)org \
--cc=auke-jan.h.kok@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox