Subject: Re: [patch 06/18] PCI-X/PCI-Express read control interfaces: use them in myrinet

From: Jeff Garzik <[email-masked]>
Date: Tue, 14 Aug 2007 01:30:13 -0400

[email-masked] wrote:
> From: "Peter Oruba" <[email-masked]>
> 
> These driver changes incorporate the proposed PCI-X / PCI-Express read byte
> count interface.  Reading and setting those valuse doesn't take place
> "manually", instead wrapping functions are called to allow quirks for some
> PCI bridges.
> 
> Signed-off by: Peter Oruba <[email-masked]>
> Based on work by Stephen Hemminger <[email-masked]>
> Cc: Roland Dreier <[email-masked]>
> Cc: Brice Goglin <[email-masked]>
> Signed-off-by: Andrew Morton <[email-masked]>
> ---
> 
>  drivers/net/myri10ge/myri10ge.c |    3 +--
>  1 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff -puN drivers/net/myri10ge/myri10ge.c~pci-x-pci-express-read-control-interfaces-myrinet drivers/net/myri10ge/myri10ge.c
> --- a/drivers/net/myri10ge/myri10ge.c~pci-x-pci-express-read-control-interfaces-myrinet
> +++ a/drivers/net/myri10ge/myri10ge.c
> @@ -2884,8 +2884,7 @@ static int myri10ge_probe(struct pci_dev
>  			status);
>  		goto abort_with_netdev;
>  	}
> -	val = (val & ~PCI_EXP_DEVCTL_READRQ) | (5 << 12);
> -	status = pci_write_config_word(pdev, cap + PCI_EXP_DEVCTL, val);
> +	status = pcie_set_readrq(pdev, 4096);

I presume Brice will resend this one to me, next time he pushes...