From: "Kok, Auke" <auke-jan.h.kok@intel•com>
To: Jeff Garzik <jeff@garzik•org>
Cc: akpm@linux-foundation•org, netdev@vger•kernel.org, bunk@stusta•de
Subject: Re: [patch 12/18] e1000: #if 0 two functions
Date: Tue, 14 Aug 2007 14:18:01 -0700 [thread overview]
Message-ID: <46C21C09.30802@intel.com> (raw)
In-Reply-To: <46C21B40.1050301@intel.com>
Kok, Auke wrote:
> Jeff Garzik wrote:
>> akpm@linux-foundation•org wrote:
>>> From: Adrian Bunk <bunk@stusta•de>
>>>
>>> e1000_{read,write}_pci_cfg() are no longer used.
>>>
>>> Signed-off-by: Adrian Bunk <bunk@stusta•de>
>>> Cc: Auke Kok <auke-jan.h.kok@intel•com>
>>> Signed-off-by: Andrew Morton <akpm@linux-foundation•org>
>>> ---
>>>
>>> drivers/net/e1000/e1000_hw.h | 2 --
>>> drivers/net/e1000/e1000_main.c | 4 ++++
>>> 2 files changed, 4 insertions(+), 2 deletions(-)
>> if it's truly dead code in upstream, we should just remove it from e1000
>
> if I apply this to #master and compile, it blows up: the two functions are still
> in use there. I also don't see any difference with current #upstream....
>
> so, I don't know what is in -mm at the moment, but we do not want this in jeff's
> tree.
whoops, I fail to correlate this with the mmrbc patch I just acked 5 minutes
ago, which removes the need for these functions.
I'll push a patch to remove these functions once I hear what the plan is for the
mmrbc patch.
Cheers,
Auke
prev parent reply other threads:[~2007-08-14 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 21:05 [patch 12/18] e1000: #if 0 two functions akpm
2007-08-14 5:36 ` Jeff Garzik
2007-08-14 21:14 ` Kok, Auke
2007-08-14 21:18 ` Kok, Auke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C21C09.30802@intel.com \
--to=auke-jan.h.kok@intel$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bunk@stusta$(echo .)de \
--cc=jeff@garzik$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox