From: Randy Dunlap <randy.dunlap@oracle•com>
To: Jiri Slaby <jirislaby@gmail•com>
Cc: Andrew Morton <akpm@linux-foundation•org>,
linux-kernel@vger•kernel.org, source@mvista•com,
dougthompson@xmission•com, bluesmoke-devel@lists•sourceforge.net,
dtor@mail•ru, linux-input@atrey•karlin.mff.cuni.cz,
netdev@vger•kernel.org, James.Bottomley@SteelEye•com,
linux-scsi@vger•kernel.org, gtolstolytkin@ru•mvista.com,
vitalywool@gmail•com, dsaxena@plexity•net, ralf@linux-mips•org,
linux-mips@linux-mips•org, mchehab@infradead•org,
video4linux-list@redhat•com, jbenc@suse•cz,
flamingice@sourmilk•net, linux-wireless@vger•kernel.org
Subject: Re: [PATCH 8/9] define global BIT macro
Date: Sat, 18 Aug 2007 11:15:25 -0700 [thread overview]
Message-ID: <46C7373D.90005@oracle.com> (raw)
In-Reply-To: <46C728CB.6060102@gmail.com>
Jiri Slaby wrote:
> Randy Dunlap napsal(a):
>> On Sat, 18 Aug 2007 11:44:12 +0200 (CEST) Jiri Slaby wrote:
>>
>>> define global BIT macro
>>>
>>> move all local BIT defines to the new globally define macro.
>>>
>>> Signed-off-by: Jiri Slaby <jirislaby@gmail•com>
>>>
>>> ---
>>>
>>> include/linux/bitops.h | 1 +
>>> include/video/sstfb.h | 1 -
>>> include/video/tdfx.h | 2 --
>>> net/mac80211/ieee80211_i.h | 2 --
>>> 18 files changed, 1 insertions(+), 37 deletions(-)
>>>
>>> diff --git a/include/linux/bitops.h b/include/linux/bitops.h
>>> index 3255b06..a57b81f 100644
>>> --- a/include/linux/bitops.h
>>> +++ b/include/linux/bitops.h
>>> @@ -3,6 +3,7 @@
>>> #include <asm/types.h>
>>>
>>> #ifdef __KERNEL__
>>> +#define BIT(nr) (1UL << (nr))
>>> #define BIT_MASK(nr) (1UL << ((nr) % BITS_PER_LONG))
>>> #define BIT_WORD(nr) ((nr) / BITS_PER_LONG)
>>> #define BITS_TO_TYPE(nr, t) (((nr)+(t)-1)/(t))
>>
>> So users of the BIT() macro in include/linux/input.h can be
>> changed to use the global BIT_MASK() macro...
>> and the former can be removed.
>
> I'm afraid I don't understand you. Maybe, you are writing about changes done in
> patch no. 7 [1], which didn't go through to the lkml?
>
> [1]
> http://www.fi.muni.cz/~xslaby/sklad/07-get-rid-of-input-bit-duplicate-defines.patch
Exactly. Thanks.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-08-18 18:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <737828602404912540@wsc.cz>
2007-08-18 9:41 ` [PATCH 4/9] s2io, rename BIT macro Jiri Slaby
2007-08-24 2:35 ` Richard Knutsson
2007-08-18 9:44 ` [PATCH 8/9] define global " Jiri Slaby
2007-08-18 16:46 ` Randy Dunlap
2007-08-18 17:13 ` Jiri Slaby
2007-08-18 18:15 ` Randy Dunlap [this message]
2007-08-22 22:03 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C7373D.90005@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=James.Bottomley@SteelEye$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bluesmoke-devel@lists$(echo .)sourceforge.net \
--cc=dougthompson@xmission$(echo .)com \
--cc=dsaxena@plexity$(echo .)net \
--cc=dtor@mail$(echo .)ru \
--cc=flamingice@sourmilk$(echo .)net \
--cc=gtolstolytkin@ru$(echo .)mvista.com \
--cc=jbenc@suse$(echo .)cz \
--cc=jirislaby@gmail$(echo .)com \
--cc=linux-input@atrey$(echo .)karlin.mff.cuni.cz \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=mchehab@infradead$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ralf@linux-mips$(echo .)org \
--cc=source@mvista$(echo .)com \
--cc=video4linux-list@redhat$(echo .)com \
--cc=vitalywool@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox