From: Jeff Garzik <jgarzik@pobox•com>
To: Florian Westphal <fw@strlen•de>
Cc: akpm@linux-foundation•org, netdev@vger•kernel.org
Subject: Re: [PATCH] DM9000: fix interface hang under load
Date: Sat, 25 Aug 2007 00:40:52 -0400 [thread overview]
Message-ID: <46CFB2D4.4010801@pobox.com> (raw)
In-Reply-To: <20070820233342.GG9315@Chamillionaire.breakpoint.cc>
Florian Westphal wrote:
> When transferring data at full speed, the DM9000 network interface
> sometimes stops sending/receiving data. Worse, ksoftirqd consumes
> 100% cpu and the net tx watchdog never triggers.
> Fix by spin_lock_irqsave() in dm9000_start_xmit() to prevent the
> interrupt handler from interfering.
>
> Signed-off-by: Florian Westphal <fw@strlen•de>
> ---
> Actually the comments ('Disable all interrupts, iow(db, DM9000_IMR, IMR_PAR) etc)
> give the impression that the interrupt handler cannot run during dm9000_start_xmit(),
> however this isn't correct (perhaps the chipset has some weird timing issues?).
> The interface lockup usually occurs between 30 and 360 seconds after starting transmitting
> data (netcat /dev/zero) at full speed; with this patch applied I haven't been able
> to reproduce hangs yet (ran for > 2h).
> FTR: This is a dm9000 on XScale-PXA255 rev 6 (ARMv5TE)/Compulab CM-x255, i.e.
> a module not supported by the vanilla kernel. Tested on (patched) 2.6.18.
>
> dm9000.c | 25 +++++++------------------
> 1 file changed, 7 insertions(+), 18 deletions(-)
applied
prev parent reply other threads:[~2007-08-25 4:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 23:33 [PATCH] DM9000: fix interface hang under load Florian Westphal
2007-08-23 9:37 ` Ben Dooks
2007-08-23 10:16 ` Florian Westphal
2007-08-25 4:40 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CFB2D4.4010801@pobox.com \
--to=jgarzik@pobox$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=fw@strlen$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox