From: Daniel Drake <dsd@gentoo•org>
To: Jesper Juhl <jesper.juhl@gmail•com>
Cc: Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Ulrich Kunitz <kune@deine-taler•de>,
linux-wireless@vger•kernel.org
Subject: Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver
Date: Thu, 30 Aug 2007 19:47:11 -0400 [thread overview]
Message-ID: <46D756FF.3090602@gentoo.org> (raw)
In-Reply-To: <9a8748490708301320o49d8e794vc5c37ffc938006f1@mail.gmail.com>
Jesper Juhl wrote:
> What would be wrong in applying my patch that removes the cast of the
> kmalloc() return value and then also remove the "__nocast" here?
We use it as a safety measure when coding. For example the write
register function takes an address and a value. We got one of these the
wrong way round once, and had a non-obvious bug.
nocast and sparse helps us prevent this.
Daniel
next prev parent reply other threads:[~2007-08-30 23:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1554af80879a7ef2f78a4d654f23c248203500d9.1187912217.git.jesper.juhl@gmail.com>
[not found] ` <1554af80879a7ef2f78a4d654f23c248203500d9.1187912217.git.jesper.juhl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2007-08-24 0:03 ` [PATCH 14/30] net: Kill some unneeded allocation return value casts in libertas Jesper Juhl
[not found] ` <2ac91f5f0eed967cf1709cfbe476b351e536c299.1187912217.git.jesper.juhl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2007-08-24 15:50 ` Dan Williams
2007-08-24 0:06 ` [PATCH 16/30] net: Avoid pointless allocation casts in BSD compression module Jesper Juhl
2007-08-25 6:25 ` David Miller
[not found] ` <c4e095af9df5ab47e7d1c8e4f3d256d74576a0c9.1187912217.git.jesper.juhl@gmail.com>
2007-08-24 7:25 ` [PATCH 12/30] net: No point in casting kmalloc return values in Gianfar Ethernet Driver Kumar Gala
[not found] ` <d551047daed1cb4d9de1eff956268a468c9837f6.1187912217.git.jesper.juhl@gmail.com>
[not found] ` <d551047daed1cb4d9de1eff956268a468c9837f6.1187912217.git.jesper.juhl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2007-08-30 17:54 ` [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver Daniel Drake
[not found] ` <46D70467.1040109-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2007-08-30 20:20 ` Jesper Juhl
2007-08-30 23:47 ` Daniel Drake [this message]
[not found] ` <9a8748490708301320o49d8e794vc5c37ffc938006f1-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-08-30 22:19 ` Joe Perches
2007-08-30 22:30 ` [PATCH] Don't needlessly initialize variable to NULL in zd_chip (was: Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver) Jesper Juhl
[not found] ` <200708310030.31713.jesper.juhl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2007-08-30 22:42 ` Randy Dunlap
[not found] ` <20070830154255.6a146c21.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2007-08-30 23:04 ` Jesper Juhl
2007-08-31 9:30 ` [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D756FF.3090602@gentoo.org \
--to=dsd@gentoo$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=jesper.juhl@gmail$(echo .)com \
--cc=kune@deine-taler$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox