Subject: Re: [PATCH 2.6.24 2/5]S2io: Handle and monitor all of the device errors and alarms

From: Jeff Garzik <[email-masked]>
Date: Fri, 31 Aug 2007 09:02:32 -0400

Ramkrishna Vepa wrote:
> - Added support to poll entire set of device errors and alarams.
> - Replaced alarm_intr_handler() with s2io_handle_errors().
> - Added statistic counters to monitor the alarms.
> 
> Signed-off-by: Sivakumar Subramani <[email-masked]>
> Signed-off-by: Santosh Rastapur <[email-masked]>
> Signed-off-by: Ramkrishna Vepa <[email-masked]>

In general I support as much error handling as is reasonable, but your 
patch description gives us no clue what the benefits of your patch are