Subject: Re: [Spam-fortigate] Re: [PATCH 1/1] netcore: minor cleanup for register_netdevice

From: FNST-Wang Chen <[email-masked]>
Date: Thu, 06 Sep 2007 13:37:55 +0800

oops
i am wrong

YOSHIFUJI Hideaki / 吉藤英明 said the following on 2007-9-6 13:34:
> I disagree.  Some of "dev->init()" functions set up dev->iflink;
> e.g., ipip_tunnel_init() etc.
>
> In article <[email-masked]> (at Thu, 06 Sep 2007 13:27:24 +0800), FNST-Wang Chen <[email-masked]> says:
>
>   
>> - minor logic cleanup
>>
>> Signed-off-by: Wang Chen <[email-masked]>
>>
>> diff -Nurp linux-2.6.22.4.org/net/core/dev.c  linux-2.6.22.4/net/core/dev.c
>> --- linux-2.6.22.4.org/net/core/dev.c    2007-08-22 15:33:40.000000000 
>> +0800
>> +++ linux-2.6.22.4/net/core/dev.c    2007-09-06 13:27:35.000000000 +0800
>> @@ -3075,8 +3075,6 @@ int register_netdevice(struct net_device
>>     dev->xmit_lock_owner = -1;
>>     spin_lock_init(&dev->ingress_lock);
>>
>> -    dev->iflink = -1;
>> -
>>     /* Init, if this function is available */
>>     if (dev->init) {
>>         ret = dev->init(dev);
>> @@ -3093,8 +3091,7 @@ int register_netdevice(struct net_device
>>     }
>>
>>     dev->ifindex = dev_new_index();
>> -    if (dev->iflink == -1)
>> -        dev->iflink = dev->ifindex;
>> +    dev->iflink = dev->ifindex;
>>
>>     /* Check for existence of name */
>>     head = dev_name_hash(dev->name);
>>
>>
>>
>>
>>
>> -
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to [email-masked]
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>     
>
>
>
>   

-- 
Best Regards,
A new email address of FJWAN is launched from Apr.1 2007.
The updated address is: [email-masked]
--------------------------------------------------
Wang Chen
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
8/F., Civil Defense Building, No.189 Guangzhou Road,
Nanjing, 210029, China
TEL：+86+25-86630566-850
FUJITSU INTERNAL：79955-850
FAX：+86+25-83317685
MAIL：[email-masked]
--------------------------------------------------