Subject: Re: [PATCH] 2.6.22.6 NETWORKING [IPV4]: Always use source addr in skb to reply packet

From: Bill Davidsen <[email-masked]>
Date: Tue, 18 Sep 2007 10:43:01 -0400

David Miller wrote:
> From: lepton <[email-masked]>
> Date: Tue, 18 Sep 2007 10:16:17 +0800
> 
>> Hi,
>>   In some situation, icmp_reply and ip_send_reply will send
>>   out packet with the wrong source addr, the following patch
>>   will fix this.
>>
>>   I don't understand why we must use rt->rt_src in the current
>>   code, if this is a wrong fix, please correct me.
>>
>> Signed-off-by: Lepton Wu <[email-masked]>
> 
> That the address is wrong is your opinion only :-)

Mine too, since an ICMP reply from an unexpected source IP is likely to 
be logged as a probe and dropped.
> 
> Source address selection is a rather complex topic, and
> here we are definitely purposefully using the source
> address selected by the routing lookup for the reply.

-- 
Bill Davidsen <[email-masked]>
   "We have more to fear from the bungling of the incompetent than from
the machinations of the wicked."  - from Slashdot