From: Jeff Garzik <jgarzik@pobox•com>
To: Markus Brunner <super.firetwister@googlemail•com>
Cc: netdev@vger•kernel.org, Mark Jonas <toertel@gmail•com>,
Paul Mundt <lethal@linux-sh•org>
Subject: Re: [PATCH] smc911x irq sense request and MPR2 board support
Date: Sat, 29 Sep 2007 01:24:47 -0400 [thread overview]
Message-ID: <46FDE19F.9000902@pobox.com> (raw)
In-Reply-To: <200708200836.51182.super.firetwister@gmail.com>
Markus Brunner wrote:
> Hi,
>
> this are the changes to the smc911x driver, which were necessary
> to get it running on the Magic Panel R2 (smsc9115).
> It is a SH3-DSP based board. The other patches are available on
> the linuxsh-dev mailinglist.
> http://marc.info/?l=linuxsh-dev&r=1&b=200708&w=2
>
> It was necessary to set the irq sense to low level.
> Therefor the SMC_IRQ_SENSE define was added.
> How are the chances for inclusion in 2.6.24?
>
> Signed-off by: Markus Brunner <super.firetwister@gmail•com>
> Signed-off by: Mark Jonas <toertel@gmail•com>
> ---
> Kconfig | 2 +-
> smc911x.c | 2 +-
> smc911x.h | 6 ++++++
> 3 files changed, 8 insertions(+), 2 deletions(-)
>
> --- sh-2.6-intc/drivers/net/Kconfig 2007-08-02 07:05:16.000000000 +0200
> +++ sh-2.6/drivers/net/Kconfig 2007-08-03 09:46:20.000000000 +0200
> @@ -944,7 +944,7 @@ config SMC911X
> tristate "SMSC LAN911[5678] support"
> select CRC32
> select MII
> - depends on ARCH_PXA
> + depends on ARCH_PXA || SUPERH
> help
> This is a driver for SMSC's LAN911x series of Ethernet chipsets
> including the new LAN9115, LAN9116, LAN9117, and LAN9118.
> --- sh-2.6-intc/drivers/net/smc911x.c 2007-07-04 21:46:34.000000000 +0200
> +++ sh-2.6/drivers/net/smc911x.c 2007-08-14 10:43:16.000000000 +0200
> @@ -2084,7 +2084,7 @@ static int __init smc911x_probe(struct n
>
> /* Grab the IRQ */
> retval = request_irq(dev->irq, &smc911x_interrupt,
> - IRQF_SHARED | IRQF_TRIGGER_FALLING, dev->name, dev);
> + IRQF_SHARED | SMC_IRQ_SENSE, dev->name, dev);
> if (retval)
> goto err_out;
>
> --- sh-2.6-intc/drivers/net/smc911x.h 2007-07-04 21:46:34.000000000 +0200
> +++ sh-2.6/drivers/net/smc911x.h 2007-08-10 13:16:34.000000000 +0200
> @@ -36,6 +36,12 @@
> #define SMC_USE_PXA_DMA 1
> #define SMC_USE_16BIT 0
> #define SMC_USE_32BIT 1
> + #define SMC_IRQ_SENSE IRQF_TRIGGER_FALLING
> +#elif CONFIG_SH_MAGIC_PANEL_R2
> + #define SMC_USE_SH_DMA 0
> + #define SMC_USE_16BIT 0
> + #define SMC_USE_32BIT 1
> + #define SMC_IRQ_SENSE IRQF_TRIGGER_LOW
> #endif
does the SuperH maintainer ACK this?
next prev parent reply other threads:[~2007-09-29 5:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 6:36 [PATCH] smc911x irq sense request and MPR2 board support Markus Brunner
2007-09-29 5:24 ` Jeff Garzik [this message]
2007-09-29 6:33 ` Paul Mundt
2007-10-02 17:35 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FDE19F.9000902@pobox.com \
--to=jgarzik@pobox$(echo .)com \
--cc=lethal@linux-sh$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=super.firetwister@googlemail$(echo .)com \
--cc=toertel@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox