From: Jeff Garzik <jgarzik@pobox•com>
To: Matteo Croce <technoboy85@gmail•com>
Cc: linux-mips@linux-mips•org, Eugene Konev <ejka@imfi•kspu.ru>,
netdev@vger•kernel.org, davem@davemloft•net,
kuznet@ms2•inr.ac.ru, pekkas@netcore•fi, jmorris@namei•org,
yoshfuji@linux-ipv6•org, kaber@coreworks•de,
Andrew Morton <akpm@linux-foundation•org>
Subject: Re: [PATCH][MIPS][7/7] AR7: ethernet
Date: Sat, 29 Sep 2007 01:39:19 -0400 [thread overview]
Message-ID: <46FDE507.90206@pobox.com> (raw)
In-Reply-To: <200709201813.48408.technoboy85@gmail.com>
Overall, looks pretty clean, good job!
Comments:
1) [major issue] Don't take and release a heavy lock on every single RX
packet.
2) remove net_device_stats from private structure, and use net_device::stats
3) rx_ring_size should not be a module param, since that should be
supported via ethtool
4) cpmac_tx_timeout() doesn't really do anything to alleviate the condition
5) don't set dev->mem_start and dev->mem_end, those are fields that are
going away, and that's not their intended purpose. just store a pointer
to the resource info.
next prev parent reply other threads:[~2007-09-29 5:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200709201728.10866.technoboy85@gmail.com>
2007-09-20 16:13 ` [PATCH][MIPS][7/7] AR7: ethernet Matteo Croce
2007-09-29 5:39 ` Jeff Garzik [this message]
[not found] <200709080143.12345.technoboy85@gmail.com>
2007-09-08 0:23 ` Matteo Croce
2007-09-12 16:50 ` Ralf Baechle
2007-09-13 1:42 ` Thiemo Seufer
2007-09-13 11:35 ` Ralf Baechle
[not found] <200708201704.11529.technoboy85@gmail.com>
2007-09-06 15:34 ` Matteo Croce
2007-09-06 22:30 ` Andrew Morton
2007-09-06 23:04 ` Randy Dunlap
2007-09-06 23:21 ` Matteo Croce
2007-09-07 0:41 ` Andrew Morton
2007-09-07 23:04 ` Jeff Garzik
2007-09-07 7:10 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FDE507.90206@pobox.com \
--to=jgarzik@pobox$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=ejka@imfi$(echo .)kspu.ru \
--cc=jmorris@namei$(echo .)org \
--cc=kaber@coreworks$(echo .)de \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pekkas@netcore$(echo .)fi \
--cc=technoboy85@gmail$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox